Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix develop build #9448

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Fix develop build #9448

merged 1 commit into from
Aug 26, 2020

Conversation

heifner
Copy link
Contributor

@heifner heifner commented Aug 26, 2020 •
edited
Loading

Change Description

  • Fix develop build
    • switch to std::optional from fc::optional and std::variant from fc::static_variant

Change Type

Select ONE

  • Documentation
  • Stability bug fix
  • Other
  • Other - special case

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

nksanthosh
nksanthosh approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@nksanthosh nksanthosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for putting this up!

@heifner heifner merged commit 7b113f4 into develop Aug 26, 2020
@heifner heifner deleted the fix-build-dev branch August 26, 2020 17:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nksanthosh nksanthosh nksanthosh approved these changes

@jeffreyssmith2nd jeffreyssmith2nd jeffreyssmith2nd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heifner @nksanthosh @jeffreyssmith2nd