Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

resolve some warnings w.r.t. copying from consts #9660

Merged
merged 1 commit into from
Nov 12, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libraries/chain/include/eosio/chain/abi_def.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -275,14 +275,14 @@ void from_variant(const fc::variant& v, eosio::chain::kv_tables_as_object<T>& o)
auto &kv_tables = o.value;
const auto& tables = v.get_object();

for( const auto table_it : tables ) {
for( const auto& table_it : tables ) {
const auto &table_obj = table_it.value().get_object();
eosio::chain::kv_table_def kv_tbl_def;
from_variant(table_obj["type"], kv_tbl_def.type);
from_variant(table_obj["primary_index"], kv_tbl_def.primary_index);
if( const auto st_it = table_obj.find("secondary_indices"); st_it != table_obj.end() ) {
const auto &sec_indices_obj = st_it->value().get_object();
for( const auto sidx_it : sec_indices_obj ) {
for( const auto& sidx_it : sec_indices_obj ) {
eosio::chain::secondary_index_def idx_def;
from_variant(sidx_it.value(), idx_def);
kv_tbl_def.secondary_indices[eosio::chain::index_name(sidx_it.key())] = idx_def;
Expand Down
2 changes: 1 addition & 1 deletion unittests/misc_tests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -674,7 +674,7 @@ BOOST_AUTO_TEST_CASE(alphabetic_sort)
std::sort(words.begin(), words.end(), std::less<string>());

vector<uint64_t> uwords;
for(const auto w: words) {
for(const auto& w: words) {
auto n = name(w.c_str());
uwords.push_back(n.to_uint64_t());
}
Expand Down