This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
disable building rodeos and eosio.tester #9670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
suggested changes
Nov 16, 2020
| auto process_all = []() { return true; }; | ||
| // This used to be "auto process_all = []() { return true; };" | ||
| // g++10 correctly reports a link error of multiple definitions | ||
| // as db_combined.hpp is included by mutiple source files. |
There was a problem hiding this comment.
I don't see that this comment adds anything. I would say remove it.
There was a problem hiding this comment.
I agree, the comment is frivolous.
larryk85
approved these changes
Nov 16, 2020
| auto process_all = []() { return true; }; | ||
| // This used to be "auto process_all = []() { return true; };" | ||
| // g++10 correctly reports a link error of multiple definitions | ||
| // as db_combined.hpp is included by mutiple source files. |
There was a problem hiding this comment.
I agree, the comment is frivolous.
heifner
approved these changes
Nov 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This PR disables building
rodeosandeosio-tester. The main goal is to remove dependencies onabieosso that we can buildeosiowith more than justclangandg++ 8(currently it fails with other flavors).After disabling rodeos and eosio-tester, it has been verified that
eosiocan be built withg++ 9andg++ 10.The changes in
db_combined.hppis for fixing multiple definition link error found byg++ 10Change Type
Select ONE
Consensus Changes
API Changes
Documentation Additions