warning fix #9681
warning fix #9681
Conversation
huangminghuang
requested review from
heifner,
TimothyBanks and
brianjohnson5972
| @@ -45,6 +45,7 @@ elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang" OR "${CMAKE_CXX_COMPILER_ID} | |||
| if (CMAKE_CXX_COMPILER_VERSION VERSION_LESS 5.0) | |||
| message(FATAL_ERROR "Clang version must be at least 5.0!") | |||
| endif() | |||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wsign-compare -Wrange-loop-analysis") | |||
There was a problem hiding this comment.
did you mean to add -Wall? (wasn't in PR desc)
There was a problem hiding this comment.
After cleaning up these warnings, what would be the thoughts on turning any new warnings into errors -Werror?
There was a problem hiding this comment.
-Werror by default is very user hostile, I'd hope it'd be an option defaulted to off
There was a problem hiding this comment.
(and potentially enabled in CI)
| @@ -98,6 +99,7 @@ else() | |||
| set(no_whole_archive_flag "--no-whole-archive") | |||
| endif() | |||
|
|
|||
| set(Boost_USE_MULTITHREADED ON) | |||
There was a problem hiding this comment.
If you have both single/multithread boost libraries installed, it would choose the multithread ones. I got a lot cmake warning messages without it.
There was a problem hiding this comment.
The default value of Boost_USE_MULTITHREADED is documented as ON.
There was a problem hiding this comment.
ah okay, Boost_USE_MULTITHREADED is default ON when using cmake's module, but
The default is to use either.
for Boost's module.
Change Description
Change Type
Select ONE
Consensus Changes
API Changes
Documentation Additions