This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
RocksDB - Renaming / creation of some parameters and change of default value for create_if_missing #9692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er and use create_if_missing=true
gssagoo
reviewed
Nov 19, 2020
gssagoo
reviewed
Nov 19, 2020
gssagoo
reviewed
Nov 19, 2020
gssagoo
suggested changes
Nov 19, 2020
Comment on lines
+313
to
+314
| ("persistent-storage-bytes-per-sync", bpo::value<uint64_t>()->default_value(config::default_persistent_storage_bytes_per_sync), | ||
| "Rocksdb write rate of flushes and compactions.") |
There was a problem hiding this comment.
Do we want its unit to be in MiB, but then it might be too coarse. If we do use MiB, here is a tricky one: you'll need to divide config::default_persistent_storage_bytes_per_sync by 1024 * 1024 here for the default value and then multiply back below.
There was a problem hiding this comment.
I was told that this value may be getting values such as 512K, that's why i didn't use the MiB here.
linhuang-blockone
approved these changes
Nov 19, 2020
gssagoo
reviewed
Nov 19, 2020
|
|
||
| // Use this option to increase the number of threads | ||
| // used to open the files. | ||
| options.max_file_opening_threads = cfg.rocksdb_threads; // Default should be the # of Cores | ||
| options.max_file_opening_threads = cfg.persistent_storage_num_threads; | ||
|
|
||
| // Write Buffer Size - Sets the size of a single | ||
| // memtable. Once memtable exceeds this size, it is | ||
| // marked immutable and a new one is created. | ||
| // Default should be 128MB |
There was a problem hiding this comment.
@victorj8 Apologies - i missed this yesterday, but can you remove the comment '// Default should be 128MB'. thanks
gssagoo
reviewed
Nov 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Changes to RocksDB parameter names:
rocksdb-threadschanged topersistent-storage-num-threadsrocksdb-fileschanged topersistent-storage-max-num-filesrocksdb-write-buffer-size-mbchanged topersistent-storage-write-buffer-size-mbNew RocksDB parameter:
persistent-storage-bytes-per-sync(used to control the write rate of flushes and compactions)Other
Change Type
Select ONE
Consensus Changes
API Changes
Documentation Additions
We need to change the documentation regarding the new parameter names and the addition of the new parameter.