Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

blockvault_client_plugin logger #9751

Merged
merged 7 commits into from
Dec 7, 2020

Conversation

huangminghuang
Copy link
Contributor

@huangminghuang huangminghuang commented Dec 5, 2020

Change Description

This PR create a new separate logger of blockvault_client_plugin and add checks for double production check for blockvault.

Change Type

Select ONE

  • Documentation
  • Stability bug fix
  • Other
  • Other - special case

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

The Loggers Section in https://developers.eos.io/manuals/eos/latest/nodeos/logging/index should add

  • blockvault_client_plugin - detailed logging for the blockvault client plugin.

Copy link
Contributor

@heifner heifner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I'm a fan of having a separate logger for this. But if you do go ahead then add this to the example in programs/nodeos/logging.json. You will also need to notify the doc team so they can add it to the documentation.

@@ -25,7 +25,7 @@ struct transform_callback : backend::sync_callback {

if (uncompressed_file.size())
target.on_snapshot(uncompressed_file.c_str());
else
else
elog("snapshot uncompress failed");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't change this one.

@huangminghuang huangminghuang merged commit dafa78f into develop Dec 7, 2020
@huangminghuang huangminghuang deleted the huangminghuang/blockvault-logger branch December 8, 2020 15:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants