This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
chain_plugin db intrinsic table RPC calls incorrectly handling --lower and --upper in certain scenarios #9805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r and --upper in certain scenarios
vzqzhang
changed the title
…tly handling --lower and --upper in certain scenarios
Added unit tests |
Removed |
linhuang-blockone
approved these changes
Dec 30, 2020
brianjohnson5972
suggested changes
Dec 30, 2020
tests/get_table_tests.cpp
Outdated
| @@ -116,6 +116,17 @@ BOOST_AUTO_TEST_CASE_TEMPLATE( get_scope_test, TESTER_T, backing_store_ts) { try | |||
| BOOST_REQUIRE_EQUAL(name("initc"_n), result.rows[1].scope); | |||
| } | |||
|
|
|||
| param.lower_bound = "initb"; | |||
| param.upper_bound = "initd"; | |||
There was a problem hiding this comment.
I missed that there was a scope with "initd", so you need to set upper_bound = "inite" (or past the last scope, so you could do param.upper_bound = "z"; which should guarantee that is past the last scope, since I doubt it has any scope values that start with "z".
brianjohnson5972
approved these changes
Jan 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
This PR fixes issue in https://blockone.atlassian.net/browse/EPE-515 where table RPC calls incorrectly handling --lower and --upper in certain scenarios
Change Type
Select ONE:
Testing Changes
Select ANY that apply:
Consensus Changes
API Changes
Documentation Additions