Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fogbugz 3431 - Action history loading spinner #102

Merged
merged 2 commits into from
May 27, 2019

Conversation

mjk90
Copy link
Contributor

@mjk90 mjk90 commented May 27, 2019

In the Action History section of Push Action page, the loading spinner has been moved inside the table so that the filter & records selector are always visible.

… and records selector are always visible.

Renamed isFetching variable to isFetchingActionHistory to differentiate it from isFetchingSmartContracts.
@varshajnagaraja varshajnagaraja added the bug Something isn't working label May 27, 2019
Copy link
Contributor

@varshajnagaraja varshajnagaraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use onChange method rather onClick, if you select the same dropdown menu then nothing should happen

…ing when the same filter is selected twice.
@mjk90 mjk90 requested a review from jcardenas9x May 27, 2019 09:36
@mjk90 mjk90 merged commit f90a73e into develop May 27, 2019
@mjk90 mjk90 deleted the action-history-loading-spinner branch May 27, 2019 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants