Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor all pollingEpic by using exhaustMap #106

Merged
merged 2 commits into from
May 28, 2019
Merged

Refactor all pollingEpic by using exhaustMap #106

merged 2 commits into from
May 28, 2019

Conversation

terrylks
Copy link
Contributor

…store isFetching check.

Remove isFetching reducers, fetch_start and fetch_end action of polling reducers.

@terrylks
Refactor all pollingEpic by using exhaustMap to replace manual redux …
fe37453 
…store isFetching check.

Remove isFetching reducers, fetch_start and fetch_end action of polling reducers.
@terrylks terrylks requested review from mjk90 and varshajnagaraja May 28, 2019 03:35
@terrylks terrylks added the enhancement New feature or request label May 28, 2019
mjk90
mjk90 approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@mjk90 mjk90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working. There's an unused import of 'store' in lastblockinfo.js but, other than that, everything is good 👍

@terrylks
Copy link
Contributor Author

Tested and working. There's an unused import of 'store' in lastblockinfo.js but, other than that, everything is good 👍

Thanks. Will remove it and merge.

@terrylks terrylks merged commit 540f3b7 into develop May 28, 2019
@terrylks terrylks deleted the exhaust-map branch May 28, 2019 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjk90 mjk90 mjk90 approved these changes

@varshajnagaraja varshajnagaraja Awaiting requested review from varshajnagaraja

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terrylks @mjk90