Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major UI and UX Updates to Deployment Page, other small fixes #12

Merged
merged 5 commits into from
May 6, 2019
Merged

Major UI and UX Updates to Deployment Page, other small fixes #12

merged 5 commits into from
May 6, 2019

Conversation

jcardenas9x
Copy link
Contributor

Deployment UI Changes / Updates

  • (3328) - Fixed the code viewer in the deployment page not scrolling properly, this was due to a CSS problem.
  • (3330) - Sanitizes the root folder path input before sending it to the API service.
  • (3337) - Remove "No successful deployment" message in the Deployment Result space in order to reduce confusion for user
  • (3350) - Adjusted alignment for many components in the deployment page, made the tooltips for Generate ABI and Deploy buttons consistent with other tooltip styling

Other Changes / Updates

  • (3336) - Remove character limit on account name. Account names still cannot start with capital letters, cannot contain capital letters, and cannot use numbers higher than 5 or the database will not store the names properly.
  • (3340) - Adjusted the alignment of the "Don't show this message again" checkbox

@jcardenas9x jcardenas9x added bug Something isn't working enhancement New feature or request labels May 6, 2019
@jcardenas9x jcardenas9x merged commit 803fd2f into develop May 6, 2019
@jcardenas9x jcardenas9x deleted the deployment-page-ui branch May 6, 2019 08:51
terrylks pushed a commit that referenced this pull request May 8, 2019
@jcardenas9x @terrylks
Major UI and UX Updates to Deployment Page, other small fixes (#12)
e4d2f62 
PR Date: 20190506
* Removed 'No successful deployment' message and also fixed drag and drop code viewer visibility'
* Additional UI fixes, removed character limit and some restrictions on account naming with updated descriptions, adjusted checkbox in popup message
* Fixed alignment in deploy contract page
* Made "Generate ABI" and "Deploy" tooltip styles consistent with other tooltips
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrylks terrylks terrylks approved these changes

@varshajnagaraja varshajnagaraja varshajnagaraja approved these changes

@mjk90 mjk90 Awaiting requested review from mjk90

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcardenas9x @varshajnagaraja @terrylks