Fogbugz 3469 - Generate a Unique Chain ID on each "init" #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varshajnagaraja
added a commit
that referenced
this pull request
Jun 10, 2019
* Split permissions in permission list UI, Refactor Edit account success flow * Import keys flow refactored * Permisiion list view logic refactored * isDefaultEosio check change * Checking keys deleted using updateAuth, showing 200 accounts maximum at a time * Added front-end logic to initialize defaultId and fetched eosio account from local node MongoDB * Updated default ID code * Adjusted default ID initialization code to check if the current default ID belong to permission with valid private key * Fixed typo * Removing constraint to edit eosio keys * Fixed problem with element not existing, it should be checked first * Code clean up * Properly updated _id when updating keys * Code clean up, check for key pairs before assigning private keys * Persist changed eosio public and private keys after resetting connection * Added check to Import Account to prevent users importing the same private key to the same account/permission repeatedly * Handle deleted keys * Page should scroll to the top on submit * Remove logs * Allow to edit keys for any permission * Make permission to be updated and the authorization permission as same * Removed redundant code from permission.js * Fogbugz 3469 - Generate a Unique Chain ID on each "init" (#120) * Add link to smart contract name in Action history of Push action page (#116) * Removed. hard coded local chain ID from permission.js * remove chain id checking from reset all permissions function * Added blockchaininfo fetchstart call to App.jsx to get chainId each time the page is reloaded. This is needed in permission page where chainId is used in an if statement. * UI changes for Create/Edit/Import form * Initialize default id refactored * Refresh the permission list when endpoint changes/resets * - Push action page - Added "Select Permission" message for cases where no default permission exists - Push action page - Added default permission handling on page load and when user clicks "Clear" - Deployment page - Added "Select Permission" message for cases where no default permission exists * Added filter to push action permission dropdown to ignore permissions without private keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed hard coded local chain ID from permission.js