Performance fix in frontend for slow loading in mongodb #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dispatch fetchStart right before calling the api. Add fetchEnd when the interval end. Add isPolling reducer for replacing isFetching in UI loading. Do not show errors when it is auto Reloading for repoll.
…polling to fetching for aciton list.
…e we want to show error immediately if the fetch is rejected / without.
… overlapping of fetching by swtich page.
… env config. Change timeout time to 2500 to 5000 for reducing retry rate.
terrylks
requested review from
mjk90,
varshajnagaraja,
jcardenas9x and
matharuajay
mjk90
approved these changes
May 15, 2019
There was a problem hiding this comment.
The changes look good to me. Tested on my machine and they seem to have solved some of the issues/bugs I've noticed with the list pages.
The only thing I noticed is that 'lastblockinfo.js' has an unused import of 'timeout'. Other than that, it all looks good 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix polling behaviour on block-list, transaction-list page, headblock and lastblockinfo and fetching behaviour on all rpc api calls to reduce the hit rate of the api calls.