Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fogbugz 3403 - Action history filter fix #56

Merged
merged 3 commits into from
May 15, 2019
Merged

Conversation

mjk90
Copy link
Contributor

@mjk90 mjk90 commented May 15, 2019

  • Removed check for actionsList length from action history filter. Filter and record count dropdowns now appear even if actionsList length is 0. This prevents users causing the filter to disappear by selecting a smart contract with no historical actions.
  • Updated Action History and Actions List page error messages to include user selected smart contract name filter.

Matthew Kelly added 2 commits May 15, 2019 17:26
…er and record count dropdowns now appear even if actionsList length is 0. This prevents users causing the filter to disappear by selecting a smart contract with no historical actions.
Copy link
Contributor

@varshajnagaraja varshajnagaraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the error message to match with others in the tool

@mjk90 mjk90 merged commit 819d3e8 into develop May 15, 2019
@mjk90 mjk90 deleted the action-history-filter-fix branch May 15, 2019 10:13
@jcardenas9x jcardenas9x added the bug Something isn't working label May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants