Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug where prefilling an action with missing ABI breaks the push action page when revisiting it #66

Merged
merged 1 commit into from
May 17, 2019
Merged

Fix a bug where prefilling an action with missing ABI breaks the push action page when revisiting it #66

merged 1 commit into from
May 17, 2019

Conversation

jcardenas9x
Copy link
Contributor

Changes

  • When connected to mainnet, fix a problem where sometimes actions that are prefilled come from smart contracts with missing ABI on the front-end. This causes the page to break.
  • The fix will display the prefilled action upon revisiting the page, but with an empty list of actions instead.

@jcardenas9x
[20190517] Properly checks if the smart contract exists and that it h…
7e77cfd 
…as an ABI with actions before initializing the action list after prefilling
@jcardenas9x jcardenas9x added the bug Something isn't working label May 17, 2019
@terrylks terrylks merged commit bfe6680 into develop May 17, 2019
@terrylks terrylks deleted the push-action-bugs branch May 17, 2019 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrylks terrylks terrylks approved these changes

@mjk90 mjk90 mjk90 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcardenas9x @mjk90 @terrylks