This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Remove warnings #655
Merged
Remove warnings #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -77,7 +76,7 @@ const rpc = new JsonRpc('http://127.0.0.1:8888', { fetch }); | |||
|
|
|||
| ### API | |||
|
|
|||
| Include textDecoder and textEncoder when using in Node, React Native, IE11 or Edge Browsers. | |||
| Include textDecoder and textEncoder when using in Node. You may exclude these when running in a browser since most modern browsers now natively support these. If your browser does not support these (https://caniuse.com/#feat=textencoder), then you can import them as a dependency through the following deprecated npm package: https://www.npmjs.com/package/text-encoding | |||
jeffreyssmith2nd
approved these changes
Feb 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Bump packages and resolve warnings from other packages.
Fixes #651
https://caniuse.com/#feat=textencoder, so this is now natively supported in ~97%+ of modern browsers and 92% of all browsers.
Tested with tropical + chrome-authenticator-app/ual-swagger.
API Changes
Documentation Additions
Removed info about pulling
TextEncoder/TextDecoderfromtext-encodingpackage since this was removed. Also updated README to tell people to just exclude these when running in a browser.