Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Webpack separating external packages and cross-platform building #827

Merged
merged 9 commits into from
Feb 10, 2021

Conversation

bradlhart
Copy link
Contributor

Change Description

Webpack has been packaging external packages with eosjs and there is a requirement to ensure that these external packages are separated in a different file. Additionally, webpack and tsc needed deletion of the files before they run and we were using rm -rf which is not crossplatform. Webpack has a plugin that can clean a directory but for tsc, I added rimraf, a cross-platform package for this use case.

Since the vendor files have been moved to externals.js and externals.min.js, these files must be included when using eosjs in the browser going forward.

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

Added a note that externals.js or externals.min.js are now required to be added in order to use eosjs

Copy link

@jamesfolk-blockone jamesfolk-blockone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It builds successfully

@bradlhart bradlhart merged commit 6067080 into develop Feb 10, 2021
@bradlhart bradlhart deleted the webpack_externals branch February 10, 2021 21:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants