Adjusting types to not require data in action from nodeos response #924
Conversation
|
I'm not quite sure I follow why the exporting of interfaces is moved from api-interfaces to rpc-interfaces. |
The reason why I moved these types is simply because the eosjs-api-interfaces.ts should include interfaces for using the API object (there's a transaction here for sending to nodeos), whereas the eosjs-rpc-interfaces.ts includes interfaces coming from nodeos through the api plugins (the transaction coming from nodeos). |
|
My understanding is that the two interfaces are distinguished by their utility, and not by the direction of message flow. Api interface is for transacting (there can be messages in both directions for transacting), and Rpc interface is for fetching state information (message flow from chain to user). So, both interfaces can have transaction related message flow from chain to the user depending on the utility. |
|
As we have new interfaces in eosjs-rpc-interfaces.ts, the documentation needs to be updated. Please check "Documentation Additions" and notify devrel. |
Change Description
Following a change on nodeos, the transaction objects returned from nodeos could possibly not include
datavariable in the action objects. The organization of the types was adjusted to clarify that there is a Transaction object that is sent to nodeos that includes thedatavariable, whereas a Transaction object returned from nodeos might not include thedatavariable.API Changes
Documentation Additions
New types will be automatically generated and added to documentation when the documentation is published. No new written documentation in this specific PR.