Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hover interaction pointer cursor (alternative) #1348

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

silvester-pari
Copy link
Collaborator

@silvester-pari silvester-pari commented Nov 4, 2024

Implemented changes

This is an alternative implementation to #1342.
Note that for now I didn't find a way to test this...

Checklist before requesting a review

Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for eoxelements ready!

Name Link
🔨 Latest commit 335a1d9
🔍 Latest deploy log https://app.netlify.com/sites/eoxelements/deploys/6728bcd2c93a9a0008daa1a5
😎 Deploy Preview https://deploy-preview-1348--eoxelements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RobertOrthofer
Copy link
Contributor

This can be tested as part of the select-interaction-tests, where pointer movement is already tested to detect correct selection of vector & vector tile features. Since this only sets the css-attribute cursor of the map-Element, so testing should be as easy as

map.getTargetElement().style.cursor === 'pointer'

@silvester-pari
Copy link
Collaborator Author

This can be tested as part of the select-interaction-tests, where pointer movement is already tested to detect correct selection of vector & vector tile features. Since this only sets the css-attribute cursor of the map-Element, so testing should be as easy as

map.getTargetElement().style.cursor === 'pointer'

THat's what I initially tried, but the click/hover simulation in Cypress doesn't produce any "real" cursor... As soon as I actually click/hover on the map as a human, the test passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants