-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git Branch Checkout & Redux Thunk #111
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… string return types
3 tasks
…s, simplifying click handling events
jettseale
suggested changes
Jun 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dispatch calls in Browser.tsx
can be simplified down now that Redux Thunks have been integrated. Besides that, just some minor changes to improve readability.
jettseale
approved these changes
Jun 19, 2020
…2.isGitRepo functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git functionality to allow per-card git branch switching so that multiple versions of a single file can simultaneously exist on the canvas. This addresses the final feature open requirement in #68.
Includes:
Redux Thunk
dependency to provide Redux middleware for writing sync and async logic that interacts with the Redux storegit2.getRepository()
simplifies, and will replace,git.extractRepo()
(currently beta)metafile2.getMetafile()
simplifies, and will replace,metafile.extractMetafile()
(currently beta)handlers.loadCard()
provides additional safeguards against missing filetype handlers and extends functionality to accept either aMetafile
or a filepath (currently beta)ErrorDialog
deserialize()
,removeUndefined()
) moved toformats.ts