Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translated languages to the language picker #204

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

ChrisJohnNOAA
Copy link
Contributor

This is based on @turnbullerin 's work here: turnbullerin/erddap@main...language_picker_fix

Fixes #168

Type of change

  • [ X ] Bug fix (non-breaking change which fixes an issue)

Checklist before requesting a review

  • [ X ] I have performed a self-review of my code
  • [ X ] My code follows the style guidelines of this project
  • [ X ] I have commented my code, particularly in hard-to-understand areas
  • [ X ] I have made corresponding changes to the documentation
  • [ X ] My changes generate no new warnings
  • [ X ] I have added tests that prove my fix is effective or that my feature works
  • [ X ] New and existing unit tests pass locally with my changes

@ChrisJohnNOAA ChrisJohnNOAA merged commit e8a9511 into ERDDAP:main Sep 27, 2024
srstsavage pushed a commit to srstsavage/erddap that referenced this pull request Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language options should be written in their own language not english
1 participant