Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix namespace in conventions.md #223

Closed
mbjones opened this issue Jun 2, 2022 · 1 comment · Fixed by #224
Closed

fix namespace in conventions.md #223

mbjones opened this issue Jun 2, 2022 · 1 comment · Fixed by #224
Assignees
@mbjones
Labels
Update Documentation updates to the guidance docs
Milestone
v1.3

Comments

@mbjones
Copy link
Collaborator

mbjones commented Jun 2, 2022

I discovered that the current CONVENTIONS.md document has an outdated section on http versus https namespace guidance, which we changed in issue 52 and added a new updated section in the Dataset guide. Need to update CONVENTIONS.md to provide the same guidance as Dataset.md. I've drafted this change and will submit as a PR shortly.
@mbjones mbjones added the Update Documentation updates to the guidance docs label Jun 2, 2022
@mbjones mbjones added this to the v1.3 milestone Jun 2, 2022
@mbjones mbjones self-assigned this Jun 2, 2022
mbjones added a commit that referenced this issue Jun 2, 2022
@mbjones
Update namespace guidance to conform with http guideline.
ab8459d 
This addresses issue #223, and pulls text from our decision document on namespace consistency.
It complements the text in the Dataset.md guide, which now says the same thing but explains it
differently.
@mbjones mbjones mentioned this issue Jun 2, 2022
Merged
@mbjones mbjones linked a pull request Jun 2, 2022 that will close this issue
Update namespace guidance to conform with http guideline. #224
Merged
@mbjones
Copy link
Collaborator Author

mbjones commented Jun 6, 2022

Done and merged into develop.

@mbjones mbjones closed this as completed Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbjones mbjones

Labels
Update Documentation updates to the guidance docs
Projects
None yet
Milestone
v1.3
Development

Successfully merging a pull request may close this issue.

Update namespace guidance to conform with http guideline. ESIPFed/science-on-schema.org
1 participant
@mbjones