python 3 format causing pylint fails

[jedwards4b]

In PR #1471 I objected to the usage of python3 syntax format statements instead of %s as used throughout the code. Now I've noticed that this usage was introduced to the trunk in PR #1388

Master is failing pylint tests due to #1388 - while fixing the pylint test can you please revert to %s usage throughout?

[erichlf]

I can do that.

[erichlf]

So the question is why wasn't pylint failing with the other python3 string formats that already existed in the code?

[jedwards4b]

I don't know, it's also not failing on cheyenne - different pylint version maybe?

[erichlf]

@jgfouca has a fix for this.

[jgfouca]

@jedwards4b I added an additional warning ignore to code_checker, so we can use python3 string formatting. Based on my discussions with Erich, I believe the python3 format is superior, so it should be a win for us to use it in the longrun.

[jedwards4b]

I am not disagreeing that format is a superior usage. I am arguing for consistent usage throughout the code. I would like to use %s for now and if another PR comes up changing all %s to format then we can consider switching.

[rljacob]

Its reasonable to change the format file-by-file as you go along rather then every file all at once.

[rljacob]

....but don't want to start that at this time while trying to harden for CESM2 release.

[rljacob]

Fixed by #1490