Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional test cases for integration tests of data_finder.py #1087

Merged
merged 2 commits into from
May 10, 2021

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Apr 27, 2021

This PR adds additional test cases for the integration tests of _data_finder.py which should make the review of #1082 easier.

Closes #1085.

There are no changes in the code itself, so I think we can merge this quickly. What do you think @valeriupredoi ?


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma self-assigned this Apr 27, 2021
@schlunma schlunma added this to the v2.3.0 milestone May 4, 2021
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers @schlunma - we should start thinking about breaking up these monster yaml configs into smaller, more manageable bits at some point, not now 👍

@valeriupredoi valeriupredoi merged commit cbd041a into master May 10, 2021
@valeriupredoi valeriupredoi deleted the improve_data_finder_tests branch May 10, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve test coverage for data_finder.py (mainly for fx variables)
2 participants