Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download instructions for the MSWEP dataset #1506

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

remi-kazeroni
Copy link
Contributor

@remi-kazeroni remi-kazeroni commented Feb 21, 2022

Description

This PR adds a link to access the version V220 of the MSWEP dataset. This version is no longer available on the source website (http://www.gloh2o.org/) but was used to develop the recipe hydrology/recipe_hydro_forcing.yml. The new link was already mentioned in #969.

Closes #1505

Link to documentation: https://esmvaltool--1506.org.readthedocs.build/projects/ESMValCore/en/1506/develop/fixing_data.html#observational-datasets


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@remi-kazeroni remi-kazeroni added the documentation Improvements or additions to documentation label Feb 21, 2022
@remi-kazeroni remi-kazeroni added this to the v2.5.0 milestone Feb 21, 2022
@remi-kazeroni remi-kazeroni self-assigned this Feb 21, 2022
@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #1506 (ad3ff53) into main (4a6b3cb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1506   +/-   ##
=======================================
  Coverage   90.74%   90.74%           
=======================================
  Files         197      197           
  Lines       10547    10547           
=======================================
  Hits         9571     9571           
  Misses        976      976           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a6b3cb...ad3ff53. Read the comment docs.

Copy link
Contributor

@Peter9192 Peter9192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, you guys are awesome with all these fixes! Great work, thanks!

@schlunma
Copy link
Contributor

Can this be merged?

@remi-kazeroni
Copy link
Contributor Author

If it is still possible to get some minor changes to the doc inv2.5, yes please. In that case, I let you merge :)

@schlunma schlunma merged commit 7711631 into main Feb 23, 2022
@schlunma schlunma deleted the fix_mswep_instructions branch February 23, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download instructions for the MSWEP data
3 participants