Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "callback" as a function argument to esmvalcore.preprocessor.load #1801

Closed
wants to merge 1 commit into from

Conversation

bouweandela
Copy link
Member

Description

This removes the callback function argument from esmvalcore.preprocessor.load.

Closes #1800.

Link to documentation:


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bouweandela bouweandela added this to the v2.8.0 milestone Nov 15, 2022
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #1801 (cb884e7) into main (4d48ece) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1801   +/-   ##
=======================================
  Coverage   91.51%   91.51%           
=======================================
  Files         202      202           
  Lines       10908    10909    +1     
=======================================
+ Hits         9982     9983    +1     
  Misses        926      926           
Impacted Files Coverage Δ
esmvalcore/_recipe.py 95.81% <100.00%> (ø)
esmvalcore/preprocessor/_ancillary_vars.py 98.57% <100.00%> (ø)
esmvalcore/preprocessor/_io.py 84.73% <100.00%> (+0.06%) ⬆️
esmvalcore/preprocessor/_regrid.py 97.11% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bouweandela
Copy link
Member Author

I'll deprecate it instead..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal to deprecate the callback argument from esmvalcore.preprocessor.load in v2.8 and remove it in v2.10.
1 participant