Adapt regridding to CORDEX needs #185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattiarighi
added
enhancement
|
This PR mixes fixes in data files with some changes to regridding that imho are likely to be unnecessary once we address other aspects of CORDEX data properly. We will have a closer look at this after the first step of making CORDEX data available, which is addressed in another PR. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, we added the coordinate system to those coordinates that have not one to avoid iris error ( better explained in #182 ).
Second, I commented out and commented in the command lines in the inverse order in order to make ESMValTool to use Iris.
Third, I opened a try/except clause in the is_lon_circular() function because lon.bounds does not exist unless you use the fix given in #184 .
This pull request is a small part of #182