Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed ignoring of scalar time coords in multi_model_statistics #1961

Merged
merged 8 commits into from
May 19, 2023

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Mar 8, 2023

Description

This PR makes the usage of the option ignore_scalar_coords=True in multi_model_statistics work for scalar time coordinates.

Closes #1960


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added the bug Something isn't working label Mar 8, 2023
@schlunma schlunma added this to the v2.9.0 milestone Mar 8, 2023
@schlunma schlunma self-assigned this Mar 8, 2023
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #1961 (c93141d) into main (5593c1a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1961   +/-   ##
=======================================
  Coverage   92.79%   92.79%           
=======================================
  Files         236      236           
  Lines       12476    12484    +8     
=======================================
+ Hits        11577    11585    +8     
  Misses        899      899           
Impacted Files Coverage Δ
esmvalcore/preprocessor/_multimodel.py 97.94% <100.00%> (+0.05%) ⬆️

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, cheers Manu! Just a couple minor points from me 🍺

esmvalcore/preprocessor/_multimodel.py Outdated Show resolved Hide resolved
esmvalcore/preprocessor/_multimodel.py Show resolved Hide resolved
esmvalcore/preprocessor/_multimodel.py Show resolved Hide resolved
@bouweandela bouweandela merged commit 8b6be3c into main May 19, 2023
@bouweandela bouweandela deleted the mm_stat_ignore_scalar_time_coord branch May 19, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ignore_scalar_coords option of multi-model statistics does not work with scalar time coordinate
3 participants