Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where data was not loaded and saved #1963

Merged
merged 3 commits into from
Mar 15, 2023

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Mar 9, 2023

Description

This fixes an issue where data was not loaded and saved if no preprocessing was needed for that particular dataset, but it was part of a variable that also had other datasets that did need preprocessing. For example: a preprocessor

    regrid:
      target_grid: CanESM2
      scheme: linear
    multi_model_statistics:
      span: full
      statistics: [mean]
      exclude: [CanESM2]

with datasets CanESM2 and at least one other dataset.

This bug was introduced in #1609 and was not part of a release.

Closes #1962


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #1963 (f96be16) into main (576a5bb) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1963      +/-   ##
==========================================
+ Coverage   92.66%   92.79%   +0.12%     
==========================================
  Files         236      236              
  Lines       12437    12437              
==========================================
+ Hits        11525    11541      +16     
+ Misses        912      896      -16     
Impacted Files Coverage Δ
esmvalcore/preprocessor/__init__.py 95.23% <100.00%> (+5.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bouweandela bouweandela added the bug Something isn't working label Mar 9, 2023
@bouweandela
Copy link
Member Author

@remi-kazeroni This works, but I'd like to add another test. I'm not working today, so if you're in a hurry you can merge this if it solves your issue and then I'll open another pull request next week to add the extra test.

@remi-kazeroni
Copy link
Contributor

@bouweandela thanks for providing the fix. It's totally fine for me to wait that you add the test before this. I'll do a bit of recipe testing early next week. My plan would be to release rc2 towards the end of next week. Would be great to have this PR in there 👍

@bouweandela bouweandela added this to the v2.8.0 milestone Mar 13, 2023
@bouweandela bouweandela marked this pull request as ready for review March 13, 2023 18:16
@remi-kazeroni remi-kazeroni self-requested a review March 15, 2023 08:27
Copy link
Contributor

@remi-kazeroni remi-kazeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bouweandela! This looks good to me. I've several recipes including the 2 that were failing prior to this PR and all works fine now 👍

@ESMValGroup/technical-lead-development-team could someone have a final look and merge, please?

@schlunma
Copy link
Contributor

Awesome, thanks @bouweandela and @remi-kazeroni 🚀

@schlunma schlunma merged commit a86c92b into main Mar 15, 2023
@schlunma schlunma deleted the fix-missing-load-if-no-preproc branch March 15, 2023 09:02
remi-kazeroni pushed a commit that referenced this pull request Mar 15, 2023
Co-authored-by: Rémi Kazeroni <remi.kazeroni@dlr.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing preprocessed OBS data when running recipe_bock20jgr_fig_1-4
3 participants