-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support loading ICON grid from ICON rootpath #2337
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2337 +/- ##
==========================================
+ Coverage 94.12% 94.13% +0.01%
==========================================
Files 241 241
Lines 13387 13410 +23
==========================================
+ Hits 12600 12623 +23
Misses 787 787 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ICON grid file is loaded correctly from the ICON rootpath specified in the configuration file and the plots are generated properly.
It is not needed anymore to declare the absolute path of the grid file in the recipe(s).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, just a few minor points from me, Manu 🍻
Co-authored-by: Valeriu Predoi <valeriu.predoi@gmail.com>
perfect in me 📖 s Manu 🍺 |
Description
Currently, the ICON grid file can either be specified via the facet
horizontal_grid
or automatically downloaded from a public website specified by theGRID_FILE_URI
attribute of the data. Since the grid file is almost always present in the ICON output directory, this PR adds support for that. If possible, the ICON grid file is now retrieved from the ICON directory specified in the user configuration file.Link to documentation: https://esmvaltool--2337.org.readthedocs.build/projects/ESMValCore/en/2337/quickstart/find_data.html#icon
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: