Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loading ICON grid from ICON rootpath #2337

Merged
merged 11 commits into from
Mar 7, 2024

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Feb 20, 2024

Description

Currently, the ICON grid file can either be specified via the facet horizontal_grid or automatically downloaded from a public website specified by the GRID_FILE_URI attribute of the data. Since the grid file is almost always present in the ICON output directory, this PR adds support for that. If possible, the ICON grid file is now retrieved from the ICON directory specified in the user configuration file.

Link to documentation: https://esmvaltool--2337.org.readthedocs.build/projects/ESMValCore/en/2337/quickstart/find_data.html#icon


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added the enhancement New feature or request label Feb 20, 2024
@schlunma schlunma added this to the v2.11.0 milestone Feb 20, 2024
@schlunma schlunma self-assigned this Feb 20, 2024
@schlunma schlunma changed the title Support loading of ICON grid that is in ICON rootpath Support loading ICON grid from ICON rootpath Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.13%. Comparing base (5941300) to head (9cd1798).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2337      +/-   ##
==========================================
+ Coverage   94.12%   94.13%   +0.01%     
==========================================
  Files         241      241              
  Lines       13387    13410      +23     
==========================================
+ Hits        12600    12623      +23     
  Misses        787      787              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@diegokam diegokam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ICON grid file is loaded correctly from the ICON rootpath specified in the configuration file and the plots are generated properly.
It is not needed anymore to declare the absolute path of the grid file in the recipe(s).

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, just a few minor points from me, Manu 🍻

esmvalcore/cmor/_fixes/icon/_base_fixes.py Outdated Show resolved Hide resolved
esmvalcore/cmor/_fixes/icon/_base_fixes.py Outdated Show resolved Hide resolved
esmvalcore/cmor/_fixes/icon/_base_fixes.py Show resolved Hide resolved
esmvalcore/cmor/_fixes/icon/_base_fixes.py Outdated Show resolved Hide resolved
schlunma and others added 2 commits March 6, 2024 17:12
Co-authored-by: Valeriu Predoi <valeriu.predoi@gmail.com>
@valeriupredoi
Copy link
Contributor

perfect in me 📖 s Manu 🍺

@schlunma schlunma merged commit 9608056 into main Mar 7, 2024
4 checks passed
@schlunma schlunma deleted the more_flexible_ICON_grid_reading branch March 7, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants