-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broadcast properly cell_measures
when using extract_shape
with decomposed: True
#2348
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2348 +/- ##
=======================================
Coverage 94.10% 94.10%
=======================================
Files 246 246
Lines 13477 13482 +5
=======================================
+ Hits 12682 12687 +5
Misses 795 795 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Saskia, looks good to me, just have two minor comments.
Co-authored-by: Manuel Schlund <32543114+schlunma@users.noreply.github.com>
Thanks for the comments @schlunma , I added a comment and changed a bit the condition to also make it work when only one region is extracted and the result cube has no description: |
This a recipe to monitor experiments by automatizing the creation of plots
from raw preprocessor output.
authors:
- vegas-regidor_javier
maintainer:
- loosveldt-tomas_saskia
datasets:
- dataset: EC-Earth3-CC
ensemble: r1i1p1f1
grid: gn
exp: historical
mip: Omon
project: CMIP6
preprocessors:
extract_two_regions:
extract_shape:
shapefile: AR6
method: contains
crop: False
decomposed: True
ids: {Acronym: [EAO, WAF]}
volume_statistics:
operator: mean
extract_one_region:
extract_shape:
shapefile: AR6
method: contains
crop: False
decomposed: True
ids: {Acronym: [EAO]}
volume_statistics:
operator: mean
diagnostics:
timeseries:
variables:
thetao_1:
short_name: thetao
timerange: '1950/1952'
preprocessor: extract_two_regions
thetao_2:
short_name: thetao
timerange: '1950/1952'
preprocessor: extract_one_region
scripts: null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Saskia for making the changes, everything looks good now! The output of the recipe looks as expected 🚀
Description
This PR makes sure that time-dependent cell measures are broadcasted properly to a cube with a
shape_id
coordinate.Closes #2347
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: