Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compilers dependency from conda environment and force install x64 git in OSX Github Action workflows #2420

Merged
merged 6 commits into from
May 15, 2024

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented May 15, 2024

Description

Closes #2419

compilers was added by @bouweandela four years ago in #603 - see #603 (comment) - I don't think we still need it but may be worth checking the docker build goes well without it anyway

OSX tests: failing with "setuptools_scm._run_cmd.CommandNotFoundError: git" - this has been seen in ESMValGroup/ESMValTool#3581 and it's not hitting just this node, but rather, it's an endemic issue related to macOS 14 on arm64:

  Image: macos-14-arm64
  Version: 20240422.3
  Included Software: https://github.com/actions/runner-images/blob/macos-14-arm64/20240422.3/images/macos/macos-14-arm64-Readme.md
  Image Release: https://github.com/actions/runner-images/releases/tag/macos-14-arm64%2F20240422.3

For some reason, the system git goes fishing when the x64 environment is activated and used - @schlunma and I had a decent debate about it in the linked Tool PR - no time to really-really understand the issue, just plop a git installer in the workflow!


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@valeriupredoi valeriupredoi added the installation Installation problem label May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.51%. Comparing base (6786bd9) to head (9741e3a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2420   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files         246      246           
  Lines       14023    14023           
=======================================
  Hits        13254    13254           
  Misses        769      769           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valeriupredoi valeriupredoi changed the title Remove compilers dependency from conda environment Remove compilers dependency from conda environment and force install x64 git in OSX Github Action workflows May 15, 2024
@valeriupredoi valeriupredoi added this to the v2.12.0 milestone May 15, 2024
Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me @valeriupredoi, could you clean up a bit?

The compilers package was needed a long time ago, when we were still installing most packages from PyPI and only those that weren't on PyPI from conda.

.github/workflows/run-tests.yml Outdated Show resolved Hide resolved
@valeriupredoi
Copy link
Contributor Author

Thanky, bud 🍺

@valeriupredoi valeriupredoi merged commit 7ce1a62 into main May 15, 2024
6 checks passed
@valeriupredoi valeriupredoi deleted the remove_compilers_dependency branch May 15, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation Installation problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove compilers from environment.yml
2 participants