-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
area_weights for cordex in area_statistics #631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool! cheers @mwjury - just a couple minor comments 🍺
oh and can you pls add a test case 🍺 |
@valeriupredoi I added the tests, could you have look please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, cheers muchly @mwjury 🍺
ready by me, @mattiarighi would be okay to test - I think it's good to go w/o testing anyway 🍺 |
Before you start, please read CONTRIBUTING.md.
Tasks
yamllint
to check that your YAML files do not contain mistakesIf you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.
Closes {Link to corresponding issue}
This is pull request is depending on #184