Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

area_weights for cordex in area_statistics #631

Merged
merged 6 commits into from
Jun 5, 2020

Conversation

mwjury
Copy link
Contributor

@mwjury mwjury commented May 6, 2020

Before you start, please read CONTRIBUTING.md.

Tasks

  • Create an issue to discuss what you are going to do, if you haven't done so already (and add the link at the bottom)
  • This pull request has a descriptive title that can be used in a changelog
  • Add unit tests
  • Public functions should have a numpy-style docstring so they appear properly in the API documentation. For all other functions a one line docstring is sufficient.
  • If writing a new/modified preprocessor function, please update the documentation
  • Circle/CI tests pass. Status can be seen below your pull request. If the tests are failing, click the link to find out why.
  • Codacy code quality checks pass. Status can be seen below your pull request. If there is an error, click the link to find out why. If you suspect Codacy may be wrong, please ask by commenting.
  • Please use yamllint to check that your YAML files do not contain mistakes
  • If you make backward incompatible changes to the recipe format, make a new pull request in the ESMValTool repository and add the link below

If you need help with any of the tasks above, please do not hesitate to ask by commenting in the issue or pull request.


Closes {Link to corresponding issue}

This is pull request is depending on #184

@bouweandela bouweandela added the preprocessor Related to the preprocessor label May 18, 2020
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! cheers @mwjury - just a couple minor comments 🍺

esmvalcore/preprocessor/_area.py Outdated Show resolved Hide resolved
esmvalcore/preprocessor/_area.py Outdated Show resolved Hide resolved
esmvalcore/preprocessor/_area.py Outdated Show resolved Hide resolved
@valeriupredoi
Copy link
Contributor

oh and can you pls add a test case 🍺

@mwjury
Copy link
Contributor Author

mwjury commented May 28, 2020

@valeriupredoi I added the tests, could you have look please.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, cheers muchly @mwjury 🍺

@valeriupredoi
Copy link
Contributor

ready by me, @mattiarighi would be okay to test - I think it's good to go w/o testing anyway 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preprocessor Related to the preprocessor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants