Use years from KCS recipe

[Emmadd]

Description

Fixes years in local_resampling.py that were not taken from the recipe.

• Closes Reference period hardcoded in KCS local_resampling, not taken from recipe #2222

https://esmvaltool--2223.org.readthedocs.build/en/2223/recipes/recipe_kcs.html

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

• 🛠 This pull request has a descriptive title
• 🛠 Code is written according to the code quality guidelines
• 🛠 Documentation is available
• 🛠 Tests run successfully
• 🛠 The list of authors is up to date
• 🛠 Any changed dependencies have been added or removed correctly
• 🛠 All checks below this pull request were successful

New or updated recipe/diagnostic

• 🧪 Recipe runs successfully

To help with the number of pull requests:

• 🙏 We kindly ask you to review two other open pull requests in this repository

[Peter9192]

@esmvalbot please run recipe_kcs.yml

[esmvalbot]

Since @Peter9192 asked, ESMValBot will run recipe recipe_kcs.yml as soon as possible, output will be generated here

[Peter9192]

Code looks good 👍

[bouweandela]

The bot has been busy solving the conda environment for the past 24 hours..

[esmvalbot]

ESMValBot is sorry to report it failed to run recipe recipe_kcs.yml: exit is 1, output has been generated here

[Peter9192]

Bot failed because of a dtype mismatch in multi-model statistics. I added it to the list of issues here: #2218 (comment)

[Peter9192]

@esmvalbot please run recipe_kcs.yml

[esmvalbot]

Since @Peter9192 asked, ESMValBot will run recipe recipe_kcs.yml as soon as possible, output will be generated here

[esmvalbot]

ESMValBot is sorry to report it failed to run recipe recipe_kcs.yml: exit is 1, output has been generated here

[Emmadd]

Still the same error with dtype mismatch...
failed to merge into a single cube. cube data dtype differs: float32 != float64

[zklaus]

@esmvalbot please run recipe_kcs.yml

[esmvalbot]

Since @zklaus asked, ESMValBot will run recipe recipe_kcs.yml as soon as possible, output will be generated here

[zklaus]

I think the dtype issue is resolved by now, see #2218 (reply in thread), ESMValGroup/ESMValCore#1237, and ESMValGroup/ESMValCore#1239.

I am afraid though that the bot is not working currently. @Emmadd, could you have a look at running the recipe manually?

[esmvalbot]

ESMValBot is sorry to report it failed to run recipe recipe_kcs.yml: exit is 1, output has been generated here

[Peter9192]

The bot crashed even before the ESMValTool installation finished 😮

[zklaus]

@esmvalbot please run recipe_kcs.yml

[esmvalbot]

Since @zklaus asked, ESMValBot will run recipe recipe_kcs.yml as soon as possible, output will be generated here

[esmvalbot]

ESMValBot is sorry to report it failed to run recipe recipe_kcs.yml: exit is 1, output has been generated here

[zklaus]

@esmvalbot please run recipe_kcs.yml

[esmvalbot]

Since @zklaus asked, ESMValBot will run recipe recipe_kcs.yml as soon as possible, output will be generated here

[esmvalbot]

ESMValBot is sorry to report it failed to run recipe recipe_kcs.yml: exit is 1, output has been generated here

[zklaus]

@esmvalbot please run recipe_kcs.yml

[esmvalbot]

Since @zklaus asked, ESMValBot will run recipe recipe_kcs.yml as soon as possible, output will be generated here

[esmvalbot]

ESMValBot is sorry to report it failed to run recipe recipe_kcs.yml: exit is 1, output has been generated here

[zklaus]

@esmvalbot please run recipe_kcs.yml

[esmvalbot]

Since @zklaus asked, ESMValBot will run recipe recipe_kcs.yml as soon as possible, output will be generated here

[esmvalbot]

ESMValBot is sorry to report it failed to run recipe recipe_kcs.yml: exit is 1, output has been generated here

[zklaus]

Unfortunately, there are still a few outstanding issues. I am bumping this to 2.5.0, but please feel free to contact me to resolve the problems asap after the release.

[schlunma]

@Emmadd Release v2.5 is approaching quickly (the feature freeze will be on 2022-02-21). Since this pull request is marked for v2.5, could you briefly comment if you further intend to include this in the new release and/or if you are facing any problems with it? Thanks!!

[schlunma]

This fails due to ValueError: 'year' not present in all datasets and coords='different'. Either add 'year' to datasets where it is missing or specify coords='minimal'., which also appears in the current main and is probably not related to this PR.

https://esmvaltool.dkrz.de/shared/esmvaltool/v2.5.0-test-rc2/recipe_kcs_20220213_153930/run/global_matching/global_matching/log.txt

[schlunma]

Just tested this again. The recipe runs fine now, and all output a looks as expected! 🎉 Thanks @Emmadd!!