Remove missing CMIP5 data from 2 recipes #2579
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the last PR to remove missing CMIP5 data from recipes. Data removed:
recipe_collins13ipcc
:recipe_perfmetrics_land_CMIP5.yml
:None of the data above can be found on ESGF nodes and CMIP5 data archive.
In both cases, removing missing data is not enough to run the recipes successfully but the data retrieval step is now completed find.
Run for recipe_perfmetrics_land_CMIP5.yml with missing data removed using v2.5.0rc4. Recipe crashes for data issue (model fix likely needed).
Run for recipe_collins13ipcc with missing data removed using v2.5.0rc4. Recipe crashes due to lack of memory on Mistral. The recipe is probably not runnable on Mistral but at least half of the diagnostics completed before the memory failure.
This PR aims at easing the future maintenance of these 2 recipes.
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
- [ ] 🛠 Any changed dependencies have been added or removed correctlyNew or updated recipe/diagnostic
[ ] 🧪 Recipe runs successfully[ ] 🧪 Figure(s) and data look as expected from literatureNew or updated data reformatting script
- [ ] 🛠 Documentation is available- [ ] 🛠 The dataset has been added to the CMOR check recipe- [ ] 🧪 Numbers and units of the data look physically meaningfulTo help with the number of pull requests: