Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove missing CMIP5 data from 2 recipes #2579

Merged
merged 3 commits into from
Mar 8, 2022
Merged

Conversation

remi-kazeroni
Copy link
Contributor

@remi-kazeroni remi-kazeroni commented Mar 8, 2022

Description

This is the last PR to remove missing CMIP5 data from recipes. Data removed:

  1. recipe_collins13ipcc:
  • tas_Amon_CESM1-CAM5-1-FV2_historical_r1i1p1*.nc
  • areacello_fx_bcc-csm1-1-m_historical_r0i0p0*.nc
  • areacello_fx_bcc-csm1-1-m_rcp85_r0i0p0*.nc
  • areacello_fx_inmcm4_historical_r0i0p0*.nc
  • areacello_fx_inmcm4_historical_r0i0p0*.nc
  • NOAA-GFDL/GFDL-CM3/rcp60/mon/atmos/Amon/r1i1p1/v20110601/rtmt_Amon_GFDL-CM3_rcp60_r1i1p1_*nc
  1. recipe_perfmetrics_land_CMIP5.yml:
  • fgco2_Omon_BNU-ESM_historical_r1i1p1*.nc

None of the data above can be found on ESGF nodes and CMIP5 data archive.

In both cases, removing missing data is not enough to run the recipes successfully but the data retrieval step is now completed find.

Run for recipe_perfmetrics_land_CMIP5.yml with missing data removed using v2.5.0rc4. Recipe crashes for data issue (model fix likely needed).

Run for recipe_collins13ipcc with missing data removed using v2.5.0rc4. Recipe crashes due to lack of memory on Mistral. The recipe is probably not runnable on Mistral but at least half of the diagnostics completed before the memory failure.

This PR aims at easing the future maintenance of these 2 recipes.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic

New or updated data reformatting script

- [ ] 🛠 Documentation is available
- [ ] 🛠 The dataset has been added to the CMOR check recipe
- [ ] 🧪 Numbers and units of the data look physically meaningful


To help with the number of pull requests:

@remi-kazeroni
Copy link
Contributor Author

Please let me know if any changes to the documentation should be done.

Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, don't think changes in the doc are necessary.

@axel-lauer
Copy link
Contributor

I also do not think the documentation needs to be updated.

@schlunma
Copy link
Contributor

schlunma commented Mar 8, 2022

Can I merge this?

@axel-lauer
Copy link
Contributor

@schlunma yes, please merge...

@schlunma schlunma merged commit 26e4ddc into main Mar 8, 2022
@schlunma schlunma deleted the fix_missing_cmip5_data branch March 8, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants