Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update obs4MIPs datasets to the latest version in recipe_autoassess_radiation_rms_Amon_obs.yml #2990

Closed
wants to merge 3 commits into from

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Jan 3, 2023

Description

Update the obs4MIPs datasets to the latest version in recipe_autoassess_radiation_rms_Amon_obs.yml. The pull request is labeled as backward incompatible because this will require moving or linking the data to a directory with the new dataset name.

Fixes part of #2974.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic


To help with the number of pull requests:

@bouweandela bouweandela changed the title Update dataset names Update obs4MIPs datasets to the latest version in recipe_autoassess_radiation_rms_Amon_obs.yml Jan 3, 2023
@bouweandela bouweandela added the requires new ESMValCore release A new release of ESMValCore is needed to solve this issue/merge this pull request.. label Jan 5, 2023
@bouweandela bouweandela added this to the v2.8.0 milestone Jan 5, 2023
@bouweandela bouweandela marked this pull request as ready for review March 13, 2023 09:43
@bouweandela bouweandela removed the requires new ESMValCore release A new release of ESMValCore is needed to solve this issue/merge this pull request.. label Mar 13, 2023
@bouweandela
Copy link
Member Author

I'm not too sure about the milestone #2974 (comment). Should it be bumped to v2.9? What do you reckon @valeriupredoi @alistairsellar?

I couldn't find the documentation for this recipe, did I miss it?

@valeriupredoi
Copy link
Contributor

I'm not too sure about the milestone #2974 (comment). Should it be bumped to v2.9? What do you reckon @valeriupredoi @alistairsellar?

I couldn't find the documentation for this recipe, did I miss it?

good bye M2.8, hello M2.9 - well spotted about the documentation, Bouwe! Here's the answer #1775 (comment) - like I say in the comment (almost 3 years old comment) - we can probably port the docs from v1 to v2, but am not 100% sure - it'd be good if @alistairsellar stepped in here 🍺

@valeriupredoi
Copy link
Contributor

BTW many thanks for this @bouweandela - I've realized I managed to brush this under a Persian rug, not even a carpet 🧹

@bouweandela
Copy link
Member Author

Closing this as the recipe is outdated and will be removed by @alistairsellar as discussed in #1775 (comment).

@bouweandela bouweandela deleted the update-obs4mips-autoassess branch March 13, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants