-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implied heat transport new diagnostic #3177
Conversation
…ransports. Includes 4 files per transport calculation: recipe, poisson solver, single model and multi model diagnostics. Committed as a separate folder - files will eventually need to be distributed to the correct /recipes and /diag_scripts directories.
@ehogan @bouweandela thanks for your reviews! I believe I've addressed all your comments, please let me know if you think anything else is needed. @ehogan , please see below specific responses to your general comments:
I've done this in commits 3a56318, ee0a670, 6306ff2. I've expanded most of the three-letter names with more meaningful names. However, there are a couple of exceptions where I think it's better to keep the original names. I've kept
Done in 449e2e9.
Done in 2f54ae3.
Done in f4f8c58. Exceptions are calls to matplotlib plotting functions that require numpy arrays as arguments.
Done in 000206c, 015eec3, 40b6081.
Only the one in the poisson solver. I've replaced the others.
That is something completely different, it provides samples of a Poisson distribution. The solver in this recipe solves the Poisson differential equation over the sphere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refreshing my stale review - my worries were just numba-related, all good, serious heavy-lifting review done by others 🍺
Nice work @alejandrobodas! 🥳
Should the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for all your hard work on addressing our review comments, @alejandrobodas! 🥳 I spotted a few minor things 😊
Co-authored-by: Emma Hogan <ehogan@users.noreply.github.com>
@ehogan thanks for spotting a few mistakes! I've fixed them as suggested. I've deleted the print statement because it didn't really provide any useful information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alejandrobodas! 🥳
🥳 Well done @mo-abodas and everyone who helped with this! |
Thanks everyone for your help! |
Co-authored-by: Francesca Pearce <francesca.pearce@metoffice.gov.uk> Co-authored-by: alejandrobodas <alejandroxtr@gmail.com> Co-authored-by: Emma Hogan <ehogan@users.noreply.github.com>
Description
This recipe implements the analysis documented in Pearce and Bodas-Salcedo (2023). If CERES-EBAF is used as input dataset then it produces the results in that paper, albeit with small differences. The differences are due to the Edition of the dataset. The paper uses the latest edition (Ed4.1), whereas the recipe uses an older edition available in obs4MIPs (Ed2.7).
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic
To help with the number of pull requests: