Fix empty language select in iOS Safari on initial page load #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pienmatla
approved these changes
Apr 18, 2023
|
Hallo @Wandmalfarbe, sehr mysteriös, dass man das so löst. Aber vielen Dank für den Pull request ;-). Mit freundlichen Grüßen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dieser PR behebt einen Bug, den ich nur auf Safari für iOS nachstellen konnte. Beim initialen Laden der Seite war das Language-Select leer, obwohl dies etwas verzögert per JavaScript mit Inhalt gefüllt wird. Diese nachträgliche State-Änderung hat Safari erstmal nicht angezeigt, bzw. sie wurde angezeigt, wenn man das Select angeklickt/angetippt hat.
Der Workaround klont einfach das komplette Select aus dem HTML, entfernt das ursprüngliche Select und arbeitet auf dem Klon. Dann funktioniert auch alles im Safari auf iOS. Den Fehler konnte ich nicht mit Safari für macOS oder auch Firefox für macOS nachstellen.
This PR fixes a bug I was only able to replicate on Safari for iOS. When the page was initially loaded, the language select was empty, although this was filled with content via JavaScript with some delay. Safari did not display this subsequent state change at first, or it was displayed when you clicked/tapped on the select.
The workaround is simply cloning the entire select from the HTML, removing the original select and working on the clone. Then everything works in Safari for iOS. I could not reproduce the error with Safari for macOS or Firefox for macOS.