Fix doc comment for pool::allocate() #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
jwellbelove
pushed a commit
that referenced
this pull request
Jul 23, 2024
jwellbelove
pushed a commit
that referenced
this pull request
Jul 28, 2024
* Fix doc comment for pool::allocate() (#914) * Fixes compiler detection with Wunder --------- Co-authored-by: Michael K <130953568+kmichaelk@users.noreply.github.com> Co-authored-by: Rafael Laya <rafaellaya@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation comment for
pool::allocate()ininclude/etl/pool.hstates that the default constructor is to be called, while according to the documentation and to the code (including the documentation comment forgeneric_pool::allocate()) it is not true.