Fix run-tests.sh script #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Chiraffollo
commented
Jul 19, 2024
Chiraffollo
commented
- Fix ordering of parameters in help info
- Change spaces to tabs in indentation of methods (unique usage of indentation)
- Fix check for number of parameters to avoid empty string as default parameter value
- Fix ordering of parameters in help info - Change spaces to tabs in indentation of methods (unique usage of indentation) - Fix check for number of parameters to avoid empty string as default parameter value
|
Review changes with SemanticDiff. |
jwellbelove
reviewed
Jul 20, 2024
test/run-tests.sh
Outdated
| @@ -142,7 +142,7 @@ fi | |||
| #****************************************************************************** | |||
| # Set the number of concurrent processes to use. | |||
| #****************************************************************************** | |||
| if [ $# -eq 2 ]; then | |||
| if [ $# -le 3 ]; then | |||
There was a problem hiding this comment.
This does not work.
./run-tests.sh 11 0 7 sets CMAKE_BUILD_PARALLEL_LEVEL to 4
There was a problem hiding this comment.
Your right. I should not try to improve my fix after testing... I will fix it.
jwellbelove
changed the base branch from
master
to
pull-request/#929-Fix-run-tests.sh-script
jwellbelove
merged commit ba14f8f
into
ETLCPP:pull-request/#929-Fix-run-tests.sh-script
63 checks passed
jwellbelove
pushed a commit
that referenced
this pull request
Jul 25, 2024
…ment # Conflicts: # test/run-tests.sh
jwellbelove
pushed a commit
that referenced
this pull request
Jul 28, 2024
* Fix run-tests.sh script - Fix ordering of parameters in help info - Change spaces to tabs in indentation of methods (unique usage of indentation) - Fix check for number of parameters to avoid empty string as default parameter value * Fix incorrect comparison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.