-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use artifacts instead of GHCR for build-kit-<reponame> #58
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>
Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>
Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>
Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>
Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>
Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>
name: Build and Push Build Kit | ||
uses: everest/everest-ci/.github/workflows/deploy-single-docker-image.yml@v1.3.1 | ||
|
||
build-build-kit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build-build-kit
sounds a bit strange
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming is hard :) I am open for suggestions
run: | | ||
docker pull --quiet ${{ env.BUILD_KIT_IMAGE }} | ||
docker load -i build-kit.tar | ||
docker image tag ${{ env.BUILD_KIT_IMAGE }} build-kit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this tag still necessary if the image has been tagged already before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not necessary but with this it is enough to just "hard code" build-kit
as image name in the following.
If it wouldn't be tagged you would need to stick to ${{ env.BUILD_KIT_IMAGE }}
everywhere which decreases readability
Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>
Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>
Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>
When running the forklow in a PR coming from a fork it is not possible to push to the Github Container Registry since secrets are not available in a "fork run".
build-kit.tar
and upload as artifactbuild-kit.tar