Support for Lumissil reset in EvseSlac #809
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Signed-off-by: Cornelius Claussen <cc@pionix.de>
corneliusclaussen
force-pushed
the
feature/evseslac_lumissil_reset
branch
from
2a74f92 to
4e61ff1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Lumissil PLC chip also requires resetting after each charging session in some setups. This PR adds this option for Lumissil.
Still in draft, as there is still a hardcoded 10s delay after the reset. We need to find a better way to detect when the chip is back on line. If it has no attached EEPROM, it takes quite a while for the host loading service to upload the firmware and config again. 10s is sufficient but we need to check if there is a better way.
Issue ticket number and link
Checklist before requesting a review