Skip to content

Commit

Permalink
Polishing.
Browse files Browse the repository at this point in the history
  • Loading branch information
SirVer committed Sep 15, 2023
1 parent 9be8679 commit 6d3dd69
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion everestrs/everestrs/build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ fn find_everest_workspace_root() -> PathBuf {

while cur_dir.parent().is_some() {
cur_dir = cur_dir.parent().unwrap().to_path_buf();
// TODO(sirver): This currently only handles the case that everest-framework is build stand
// TODO(hrapp): This currently only handles the case that everest-framework is build stand
// alone - which is probably mostly unconvential. In an everest-core build, we should try
// to find the necessary libraries in dist or maybe in _deps/everest-framework-build/lib/.
if cur_dir.join("everest-framework").is_dir() {
Expand Down
4 changes: 2 additions & 2 deletions everestrs/everestrs/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ impl ffi::JsonBlob {
}

fn deserialize<T: DeserializeOwned>(self) -> T {
// TODO(sirver): Error handling
// TODO(hrapp): Error handling
serde_json::from_slice(self.as_bytes()).unwrap()
}

Expand Down Expand Up @@ -125,7 +125,7 @@ impl<T: GenericModule> Runtime<T> {
&*self.module_impl.as_ref() as *const T as *const c_char
}

// TODO(sirver): This function could use some error handling.
// TODO(hrapp): This function could use some error handling.
pub fn from_commandline(module_impl: T) -> Self {
let args: Args = argh::from_env();
let mut cpp_module = ffi::create_module(
Expand Down
2 changes: 1 addition & 1 deletion everestrs/everestrs_sys/everestrs_sys.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class Module {
CommandMeta meta,
rust::Fn<JsonBlob(const CommandMeta&, JsonBlob)> command_handler) const;

// TODO(sirver): Add call_command, publish_variable and subscribe_variable.
// TODO(hrapp): Add call_command, publish_variable and subscribe_variable.

private:
const std::string module_id_;
Expand Down

0 comments on commit 6d3dd69

Please sign in to comment.