Make controller RPC timeout configurable #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-w50
approved these changes
Oct 2, 2023
Comment on lines
+243
to
+249
| const auto settings_controller_rpc_timeout_ms_it = settings.find("controller_rpc_timeout_ms"); | ||
| if (settings_controller_rpc_timeout_ms_it != settings.end()) { | ||
| controller_rpc_timeout_ms = settings_controller_rpc_timeout_ms_it->get<int>(); | ||
| } else { | ||
| controller_rpc_timeout_ms = defaults::CONTROLLER_RPC_TIMEOUT_MS; | ||
| } | ||
|
|
There was a problem hiding this comment.
how about
controller_rpc_timeout_ms = settings.value("controller_rpc_timeout_ms", defaults::CONTROLLER_RPC_TIMEOUT_MS);?
There was a problem hiding this comment.
good idea, right now it just follows the style of the surrounding code, we should probably refactor this in a different PR though
Also make it available to the admin panel Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
hikinggrass
force-pushed
the
kh-configurable-rpc-timeout
branch
from
8e6cf60
to
cea732d
Compare
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also make it available to the admin panel