Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang-format fixes #121

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

andistorm
Copy link
Contributor

@andistorm andistorm commented Nov 15, 2023

Fixes clang-format issues of the last PR

After pushing the latest commit, the 'Lint' check wasn't ready and wasn't displayed. This is why I accidently merged the PR without running all checks.

Now I updated the branch protection rules to require all three checks, to prevent this in future:

  • Lint
  • Codacy
  • DCO

With this the checks, become displayed instantly

Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>
@hikinggrass
Copy link
Contributor

Thanks!

@andistorm andistorm merged commit 3bfa206 into main Nov 15, 2023
3 checks passed
@andistorm andistorm deleted the feature/add-error-features-for-js-modules branch November 15, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants