Fix missing Exception throw on loading config #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we move this check into load_yaml itself? @a-w50 we're using load_yaml in quite a few places in the code and I don't see any usage that would rely on returning a nullptr in case of a broken/empty yaml here. Or am I missing something? |
a-w50
requested changes
Nov 16, 2023
andistorm
commented
Nov 17, 2023
In case of laoding a broken config.yaml the function load_yaml returns a nullptr. This fix avoid accessing non-existing elements on a nullptr. Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>
Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>
* Treat null config as empty config * Check for wrong type, should be json::object Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>
Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>
andistorm
force-pushed
the
bugfix/loading-broken-config
branch
from
8ab9ee4
to
18e92f8
Compare
a-w50
approved these changes
Nov 20, 2023
hikinggrass
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of loading a broken config.yaml the function load_yaml returns a nullptr. This fix avoid accessing non-existing elements on a nullptr.