Remove some more throws in error framework #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cornelius Claussen <cc@pionix.de>
andistorm
requested changes
Jun 7, 2024
andistorm
reviewed
Jun 7, 2024
Co-authored-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de> Signed-off-by: corneliusclaussen <62659547+corneliusclaussen@users.noreply.github.com>
Co-authored-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de> Signed-off-by: corneliusclaussen <62659547+corneliusclaussen@users.noreply.github.com>
Signed-off-by: Cornelius Claussen <cc@pionix.de>
Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>
* Add log message Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>
Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>
Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>
Signed-off-by: Andreas Heinrich <andreas.heinrich@rwth-aachen.de>
andistorm
force-pushed
the
bugfix/remove_more_throws_errorframework
branch
from
94acc67
to
e77bbde
Compare
andistorm
approved these changes
Jun 13, 2024
hikinggrass
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some more throws in error framework. They should never really happen, but if it does it is not critical enough to shut down the whole system.