Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose mappings of requirements, provides and modules to modules #154

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

hikinggrass
Copy link
Contributor

@hikinggrass hikinggrass commented Oct 6, 2024

This exposes functionality introduced in EVerest/everest-framework#206 to the modules

This needs EVerest/everest-cmake#14 because ev-cli is installed during configure from now on

Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
This needs EVerest/everest-cmake#12

Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@andistorm
Copy link
Contributor

Would be nice to be able to "build" everest-utils without everest-core, this is currently not possible since the python executable isn't set by everest-utils

Options

1. Similiar to everest-core

option(${PROJECT_NAME}_USE_PYTHON_VENV "Use python venv" ON)
set(${PROJECT_NAME}_PYTHON_VENV_PATH "${CMAKE_BINARY_DIR}/venv" CACHE PATH "Path to python venv")

ev_setup_python_executable(
    USE_PYTHON_VENV ${${PROJECT_NAME}_USE_PYTHON_VENV}
    PYTHON_VENV_PATH ${${PROJECT_NAME}_PYTHON_VENV_PATH}
)

2. Error if Python3_Executable not set

if(NOT Python3_Executeable)
    message(FATAL_ERROR "Python3_Executeable not set")
endif()

3. Set Python3_Executable only if not already set

if(NOT Python3_Executeable)
    find_package(Python3 REQUIRED COMPONENTS Interpreter Development)
endif()

Option 1 is probably harder to use since you have to worry about more cmake variables when building everest-core, Option 2 doesn't allow building isolated, but gives a suitable error message
Option 3 doesn't allow to use "automatic" venv when building isolated

@@ -1,2 +1,2 @@
"""EVerest command line utility."""
__version__ = '0.2.1'
__version__ = '0.2.2'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just wondering whether this version shouldn't be in sync with the repo tags?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's a bit of an API change for modules I'd say I should probably at least bump it to 0.3.0, but that's a good point. The tagging of this repo doesn't really follow the versions of its content (ev-cli and everest-testing are bot at different versions at the moment).
This probably isn't going to be an issue for long, I'm preparing a PR at the moment that would move ev-cli into everest-core with the intention of keeping it a bit closer to the code it ultimately generates (everest-framework would also be a candidate for that)

…e templates

Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
This reverts commit a2931fd.

Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
This reverts commit cf6a187.

Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
… and type templates"

This reverts commit 080be56.

Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
# Conflicts:
#	ev-dev-tools/src/ev_cli/__init__.py

Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Copy link
Contributor

@andistorm andistorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐧

Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass hikinggrass marked this pull request as draft October 17, 2024 14:21
Mappings are now included in Fulfillments not Requirements anymore

Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants