-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose mappings of requirements, provides and modules to modules #154
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
This needs EVerest/everest-cmake#12 Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Would be nice to be able to "build" everest-utils without everest-core, this is currently not possible since the python executable isn't set by everest-utils Options 1. Similiar to everest-core
2. Error if Python3_Executable not set
3. Set Python3_Executable only if not already set
Option 1 is probably harder to use since you have to worry about more cmake variables when building everest-core, Option 2 doesn't allow building isolated, but gives a suitable error message |
ev-dev-tools/src/ev_cli/__init__.py
Outdated
@@ -1,2 +1,2 @@ | |||
"""EVerest command line utility.""" | |||
__version__ = '0.2.1' | |||
__version__ = '0.2.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just wondering whether this version shouldn't be in sync with the repo tags?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's a bit of an API change for modules I'd say I should probably at least bump it to 0.3.0, but that's a good point. The tagging of this repo doesn't really follow the versions of its content (ev-cli and everest-testing are bot at different versions at the moment).
This probably isn't going to be an issue for long, I'm preparing a PR at the moment that would move ev-cli into everest-core with the intention of keeping it a bit closer to the code it ultimately generates (everest-framework would also be a candidate for that)
…e templates Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
This reverts commit a2931fd. Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
This reverts commit cf6a187. Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
… and type templates" This reverts commit 080be56. Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
# Conflicts: # ev-dev-tools/src/ev_cli/__init__.py Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐧
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Mappings are now included in Fulfillments not Requirements anymore Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
This exposes functionality introduced in EVerest/everest-framework#206 to the modules
This needs EVerest/everest-cmake#14 because ev-cli is installed during configure from now on