Be able to raise and clear error in test controller #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
This was referenced Nov 27, 2024
Pietfried
reviewed
Nov 27, 2024
| @@ -86,6 +86,26 @@ def diode_fail(self, connector_id=1): | |||
| f"{self._mqtt_external_prefix}everest_external/nodered/{connector_id}/carsim/cmd/execute_charging_session", | |||
| "sleep 1;iec_wait_pwr_ready;sleep 1;draw_power_regulated 32,3;sleep 5;diode_fail;sleep 36000;unplug") | |||
|
|
|||
| def raise_error(self, connector_id=1): | |||
There was a problem hiding this comment.
It would be nice if one could specify an error string here, it can still default to MREC6UnderVoltage
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Pietfried
approved these changes
Nov 28, 2024
…ted and removed) Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for reservation tests.
See other related pull requests:
EVerest/everest-core#972
EVerest/libocpp#878