Adding missing dependency for gtest #136
Conversation
Signed-off-by: Robert de Leeuw, PIONIX <robert@pionix.de>
README.md
Outdated
| @@ -419,7 +419,7 @@ TODO | |||
| For Debian GNU/Linux 11 you will need the following dependencies: | |||
|
|
|||
| ```bash | |||
| sudo apt install build-essential cmake python3-pip libboost-all-dev libsqlite3-dev libssl-dev | |||
| sudo apt install build-essential cmake python3-pip libboost-all-dev libsqlite3-dev libssl-dev libgtest-dev | |||
There was a problem hiding this comment.
I think this would be great in a small new section for testing, something along the lines of:
Unit testing
If you want to run the unit tests in the tests subdirectory, you need googletest as a dependency.
For Debian GNU/Linux 11 you can install it like this:
sudo apt install libgtest-devThere was a problem hiding this comment.
@hikinggrass Hmmm, I thought I got an error during building of libocpp due to missing gtest.
I have removed libgtest-dev from my machine and tried again. I can build without, so you are right, this is not part of the build.
Is libocpp itself does not have tests, I think we can drop this pull request
There was a problem hiding this comment.
I assume you built it with -DBUILD_TESTING=ON which will build the unit tests we have in https://github.com/EVerest/libocpp/tree/main/tests that require gtest
Added two missing dependencies Signed-off-by: Robert de Leeuw, PIONIX <robert@pionix.de>
* Adding missing dependency for gtest * Create new section about unit testing Added two missing dependencies --------- Signed-off-by: Robert de Leeuw, PIONIX <robert@pionix.de>
No description provided.