Add partial trigger message support #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marc Emmers <m.emmers@alfen.com>
Signed-off-by: Marc Emmers <m.emmers@alfen.com>
…atus notification Signed-off-by: Marc Emmers <m.emmers@alfen.com>
…nd added connectorId check just to be sure Signed-off-by: Marc Emmers <m.emmers@alfen.com>
Signed-off-by: Marc Emmers <m.emmers@alfen.com>
Signed-off-by: Marc Emmers <m.emmers@alfen.com>
Signed-off-by: Marc Emmers <m.emmers@alfen.com>
marcemmers
force-pushed
the
me-trigger-message
branch
from
11d8e00
to
a13a091
Compare
Signed-off-by: Marc Emmers <m.emmers@alfen.com>
marcemmers
force-pushed
the
me-trigger-message
branch
from
a13a091
to
a59b136
Compare
Pietfried
requested changes
Aug 24, 2023
|
Also the note in F06.FR.11 looks to me as, this requirement is not applied to StatusNotification messages. |
|
I was referring to an older version of the spec... sorry for the confusion. |
Signed-off-by: Marc Emmers <m.emmers@alfen.com>
Pietfried
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still missing the following messages:
We are free to not implement messages as long as we return
NotImplementedwhich is what we currently do.Edit: I was able to implement LogStatusNotification and FirmwareStatusNotification as well but could not test it due to the logging not being implemented in everest/core yet or not being able to test the firmware update from the ocpp-testing code.