-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add partial trigger message support #145
Conversation
Signed-off-by: Marc Emmers <m.emmers@alfen.com>
Signed-off-by: Marc Emmers <m.emmers@alfen.com>
…atus notification Signed-off-by: Marc Emmers <m.emmers@alfen.com>
…nd added connectorId check just to be sure Signed-off-by: Marc Emmers <m.emmers@alfen.com>
Signed-off-by: Marc Emmers <m.emmers@alfen.com>
Signed-off-by: Marc Emmers <m.emmers@alfen.com>
Signed-off-by: Marc Emmers <m.emmers@alfen.com>
11d8e00
to
a13a091
Compare
Signed-off-by: Marc Emmers <m.emmers@alfen.com>
a13a091
to
a59b136
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Marc, apart from some minor requested changes this looks good to me. The StatusNotification trigger for all evse is missing. Have a look at the note in F06.FR.11
Also the note in F06.FR.11 looks to me as, this requirement is not applied to StatusNotification messages. |
I was referring to an older version of the spec... sorry for the confusion. |
Signed-off-by: Marc Emmers <m.emmers@alfen.com>
Still missing the following messages:
We are free to not implement messages as long as we return
NotImplemented
which is what we currently do.Edit: I was able to implement LogStatusNotification and FirmwareStatusNotification as well but could not test it due to the logging not being implemented in everest/core yet or not being able to test the firmware update from the ocpp-testing code.